Skip to content

Restoring quota patch overwritten during 2019-06-01 version update#7251

Merged
erich-wang merged 8 commits intoAzure:masterfrom
akshataP:akpati/resore-quota-patch
Sep 21, 2019
Merged

Restoring quota patch overwritten during 2019-06-01 version update#7251
erich-wang merged 8 commits intoAzure:masterfrom
akshataP:akpati/resore-quota-patch

Conversation

@akshataP
Copy link
Copy Markdown
Contributor

@akshataP akshataP commented Sep 18, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation bot commented Sep 18, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 0e25b55, Iteration 1)

Warning .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
  • No packages generated.
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Succeeded JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@AutorestCI AutorestCI mentioned this pull request Sep 18, 2019
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 18, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#7352

@akshataP
Copy link
Copy Markdown
Contributor Author

akshataP commented Sep 18, 2019

This PR is trying to restore the changes introduced by PR: https://github.com/Azure/azure-rest-api-specs/pull/6656/files
but were mistakenly overwritten by the PR: #6432

@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented Sep 18, 2019

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Sep 18, 2019
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 18, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5847

@erich-wang erich-wang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 19, 2019
@majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 20, 2019
majastrz
majastrz approved these changes Sep 20, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed off from ARM side.

@erich-wang erich-wang merged commit 72d29c4 into Azure:master Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@majastrz majastrz majastrz approved these changes

@erich-wang erich-wang Awaiting requested review from erich-wang

Assignees

@erich-wang erich-wang

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@akshataP @AutorestCI @azuresdkci @majastrz @erich-wang